-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix file+noindex URI usage on Windows #10746
base: master
Are you sure you want to change the base?
Conversation
89c9df2
to
19fad89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Terrific! Any chance for a test?
I can't push because Git operations on github are down at the moment. Will push tomorrow. As for the tests @ulysses4ever, the current test-suite makes use of this both by the roundtrip of project configurations and by some tests that make use of local+noindex repos such as the ones added recently by @9999years. I consider that sufficient testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows paths are so tricky
It's just that if anything in the current setup exercises this functionality, I expect the setup to need an update after these changes. |
The previous PR that was merged did change the OutputNormalizer. It then worked with //./ paths. Now it works with file+noindex:C:/ paths. |
19fad89
to
5ee181b
Compare
5ee181b
to
70afe9b
Compare
One could argue that the right syntax would be:
But that is not understood by
In any case .NET also supports the syntax we use here so it should be fine:
Probably the right thing to do would be to make use of
cc @hasufell |
Concluded on using
file+noindex:C:/some/path
on Windows as discussed on Matrix.Template Α: This PR modifies behaviour or interface
Include the following checklist in your PR:
significance: significant
in the changelog file.